Issue 9029 #224
Merged
Issue 9029 #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to set special `skip-update` feature for idividual qubes to suppress Qubes Update systray widget notifications on them. fixes: QubesOS/qubes-issues#9029
alimirjamali
force-pushed
the
issue-9029
branch
2 times, most recently
from
a020e83 to
bcc6bc8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 93.72% 93.61% -0.12%
==========================================
Files 57 57
Lines 10845 10892 +47
==========================================
+ Hits 10165 10197 +32
- Misses 680 695 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marmarta
suggested changes
Oct 24, 2024
alimirjamali
force-pushed
the
issue-9029
branch
from
bcc6bc8 to
986fc5d
Compare
marmarta
suggested changes
Oct 25, 2024
For `check_support` and `check_update`, it is more convenient to catch exceptions within the helper functions once.
alimirjamali
force-pushed
the
issue-9029
branch
from
1abe32d to
276c164
Compare
marmarta
approved these changes
Oct 28, 2024
marmarek
reviewed
Nov 6, 2024
|
|
||
| def domain_added(self, _submitter, _event, vm, *_args, **_kwargs): | ||
| def domain_added(self, _submitter, _event, vmname, *_args, **_kwargs): |
There was a problem hiding this comment.
This is wrong, "vm" is used as keyword argument, so you can't change its name. I'll fix it.
I should have put that through openQA earlier...
There was a problem hiding this comment.
Ops. Sorry for mistake. I wonder why it did not show up during the unit tests. I guess there is no unit test for installing an outdated or obsolete template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: QubesOS/qubes-issues#9029